Extract embedded captions while processing file #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masaball
force-pushed
the
caption_extraction
branch
from
ba5ebd1 to
bfc4624
Compare
cjcolvar
reviewed
Jan 21, 2025
There was a problem hiding this comment.
Thinking this over, I'm wondering about changing up the metadata in a few ways. Let me know what you think. I'm happy to talk over anything especially if this isn't clear.
- Input tech metadata: change
subtitle_countintosubtitleswhich is an array of hashes that contain language, label, and format (e.g.srt,vtt,tx3g) - Output tech metadata: same as input tech metadata (output video derivatives can then report if they have subtitles embedded)
- Fold
SubtitleTechnicalMetadataintoTechnicalMetadataby addingformatandlanguage - Subtitle output files can set
formatandlanguageusing technical metadata andlabelusingActiveEncode::Output. - I think the subtitle output file
formatcan always be set tovttand doesn't need to be read from the input metadata.
masaball
commented
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video files can have captions/subtitles tracks embedded in them. We can facilitate the use of these tracks by implementers by extracting them during file transcoding/processing and writing them out as additional, separate outputs.